use spack commit from config for generating spack view #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcumming
pushed a commit
that referenced
this pull request
Nov 12, 2024
* Revert "use spack commit from config for generating spack view (#199)" This reverts commit 4ce4885. * Convert spack git commit stdout byte array to string before using in template The stdout byte array is printed as b'<commit hash>' which will be interpreted in the Makefile as a string with a prefix of b. Explicitly decoding the byte array to a string first ensures the git commit will be printed without extra quotes or prefixes in the Makefile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.